Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/disable rhel8+ security plugin #266

Merged
merged 7 commits into from
Oct 7, 2024

Conversation

feng-j678
Copy link
Contributor

@feng-j678 feng-j678 commented Sep 23, 2024

[x] per BUG item 28214906 - disable yum install security plugin on rhel8+ images
test result:
rhel810 images
image
prior code change assessment call:
image
post code change assessment call;
image
post code change installation call:
image
image

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.10%. Comparing base (89b35c0) to head (fce2f30).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
+ Coverage   91.08%   91.10%   +0.02%     
==========================================
  Files          91       91              
  Lines       15848    15893      +45     
==========================================
+ Hits        14435    14480      +45     
  Misses       1413     1413              
Flag Coverage Δ
python27 91.10% <100.00%> (+0.02%) ⬆️
python39 91.10% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@feng-j678 feng-j678 marked this pull request as ready for review September 23, 2024 16:02
Copy link
Collaborator

@kjohn-msft kjohn-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments inline.

Copy link
Contributor

@rane-rajasi rane-rajasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments inline

src/core/src/package_managers/YumPackageManager.py Outdated Show resolved Hide resolved
src/core/src/package_managers/YumPackageManager.py Outdated Show resolved Hide resolved
src/core/tests/Test_YumPackageManager.py Show resolved Hide resolved
@feng-j678 feng-j678 merged commit 82f45bb into master Oct 7, 2024
7 checks passed
@feng-j678 feng-j678 deleted the bugfix/disable_rhel8+_security_plugin branch October 7, 2024 17:11
@feng-j678 feng-j678 mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants